HTML API: Test improvements #7030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_token_name will be the tag name when on tags, or a meaningful token name otherwise. This is helpful in test failure message in case we may not be on a tag.
assertSame (strict equals) should be preferred when possible.
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
pento
pushed a commit
that referenced
this pull request
Jul 17, 2024
Follow-up after feedback to newly-introduced tests, mostly to enhance the message when the tests fail. Developed in #7030 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58592]. Props dmsnell, jonsurrell. See #61646. git-svn-id: https://develop.svn.wordpress.org/trunk@58741 602fd350-edb4-49c9-b593-d223f7449a82
19 tasks
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 17, 2024
Follow-up after feedback to newly-introduced tests, mostly to enhance the message when the tests fail. Developed in WordPress/wordpress-develop#7030 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58592]. Props dmsnell, jonsurrell. See #61646. Built from https://develop.svn.wordpress.org/trunk@58741 git-svn-id: http://core.svn.wordpress.org/trunk@58143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jul 17, 2024
Follow-up after feedback to newly-introduced tests, mostly to enhance the message when the tests fail. Developed in WordPress/wordpress-develop#7030 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58592]. Props dmsnell, jonsurrell. See #61646. Built from https://develop.svn.wordpress.org/trunk@58741 git-svn-id: https://core.svn.wordpress.org/trunk@58143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Debarghya-Banerjee
pushed a commit
to Debarghya-Banerjee/wordpress-develop
that referenced
this pull request
Jul 18, 2024
Follow-up after feedback to newly-introduced tests, mostly to enhance the message when the tests fail. Developed in WordPress#7030 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58592]. Props dmsnell, jonsurrell. See #61646. git-svn-id: https://develop.svn.wordpress.org/trunk@58741 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to:
Trac ticket: https://core.trac.wordpress.org/ticket/61646
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.